Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cancel macrotask when element destroyed #6791

Merged
merged 2 commits into from
Feb 19, 2024
Merged

fix: cancel macrotask when element destroyed #6791

merged 2 commits into from
Feb 19, 2024

Conversation

splincode
Copy link
Member

No description provided.

@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Feb 14, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@splincode splincode force-pushed the splincode/cherry-pick branch 2 times, most recently from 77f6218 to 96c0ed2 Compare February 14, 2024 13:07
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 14, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 94d899c):

https://taiga-ui--pr6791-splincode-cherry-pic-olc70585.web.app

(expires Tue, 20 Feb 2024 14:32:50 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@bundlemon BundleMon
Copy link

bundlemon bot commented Feb 14, 2024 •
edited
Loading

BundleMon

Files updated (1)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 384.61KB (-44B -0.01%) +10%
Unchanged files (4)
Status Path Size Limits
✅ demo/browser/vendor.(hash).js
 213.01KB +10%
✅ demo/browser/runtime.(hash).js
 40.65KB +10%
✅ demo/browser/polyfills.(hash).js
 11.25KB +10%
✅ demo/browser/styles.(hash).css
 1.39KB +10%

Total files change -40B -0.01%

Groups updated (1)
Status Path Size Limits
✅ demo/browser/*..js
 2.36MB (+431B +0.02%) -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@splincode splincode force-pushed the splincode/cherry-pick branch from 96c0ed2 to 679ffe0 Compare February 14, 2024 13:17
@codecov Codecov
Copy link

codecov bot commented Feb 14, 2024 •
edited
Loading

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (v3.x@b079160). Click here to learn what that means.

❗ Current head 679ffe0 differs from pull request most recent head 94d899c. Consider uploading reports for the commit 94d899c to get more accurate results

Files Patch % Lines
...mponents/sheet/components/sheet/sheet.component.ts 30.00% 7 Missing ⚠️
.../kit/components/input-time/input-time.component.ts 40.00% 3 Missing ⚠️
...charts/components/arc-chart/arc-chart.component.ts 60.00% 2 Missing ⚠️
...nents/mobile-calendar/mobile-calendar.component.ts 0.00% 2 Missing ⚠️
...heet/directives/sheet-stop/sheet-stop.directive.ts 33.33% 2 Missing ⚠️
...nents/input-date-time/input-date-time.component.ts 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             v3.x    #6791   +/-   ##
=======================================
  Coverage        ?   71.96%           
=======================================
  Files           ?     1457           
  Lines           ?    16032           
  Branches        ?     2298           
=======================================
  Hits            ?    11537           
  Misses          ?     4121           
  Partials        ?      374
Flag Coverage Δ
addon-charts 71.52% <60.00%> (?)
addon-doc 60.58% <ø> (?)
addon-mobile 60.50% <26.66%> (?)
addon-table 60.75% <ø> (?)
addon-tablebars 96.15% <ø> (?)
cdk 78.48% <ø> (?)
core 77.61% <ø> (?)
kit 70.28% <71.42%> (?)
summary 71.96% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@splincode splincode added the v3 label Feb 14, 2024
@splincode splincode merged commit d6d06c9 into v3.x Feb 19, 2024
9 of 21 checks passed
@splincode splincode deleted the splincode/cherry-pick branch February 19, 2024 14:30
This was referenced Feb 20, 2024
Merged
Merged
@taiga-family-bot taiga-family-bot mentioned this pull request Mar 4, 2024
Merged
@taiga-family-bot taiga-family-bot mentioned this pull request Mar 12, 2024
Merged
This was referenced Mar 19, 2024
Merged
Merged
This was referenced Apr 2, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimirpotekhin vladimirpotekhin vladimirpotekhin approved these changes

@nsbarsukov nsbarsukov nsbarsukov approved these changes

@waterplea waterplea Awaiting requested review from waterplea waterplea is a code owner

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner

Assignees

@splincode splincode

Labels
ready to merge v3
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@splincode @nsbarsukov @vladimirpotekhin